feat: add new name order pattern nickname (first name/last name) (completing #3446) #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
asbiin
approved these changes
May 3, 2020
There was a problem hiding this comment.
That's great @vwvw !
Can you please add some tests in ContactTest@name_attribute_returns_name_in_the_right_order function?
|
Tests should be fine now. Let me know if you want more! |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #3446 looked stale, I completed it. Thanks @maantje for the initial work!
As requested in #3139, this PR introduces two new name patterns:
- ( ), which would resort to if there is no nickname
Close #3139
Supersede #3446
(Is there a way to contribute directly to an open PR? Without having the PR-Opener merging my own code in his branch?)