Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove authentication with login + password for carddav #3830

Merged
merged 3 commits into from
Apr 12, 2020

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Apr 12, 2020

This authentication is not 100% secure, and it can bypass 2fa.
From now, authentication for carddav must use API Token.

Use login + Token, or just the token on your carddav app.

Fix #3829

@asbiin asbiin force-pushed the 2020-04-12-auth-carddav branch from 4057b9c to b62419d Compare April 12, 2020 20:26
@asbiin asbiin merged commit 9159753 into master Apr 12, 2020
@asbiin asbiin deleted the 2020-04-12-auth-carddav branch April 12, 2020 20:45
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication for Cardav is not working
1 participant