Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: services to set and clear personal description #3573

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Feb 12, 2020

This PR adds two new services:

  • one to set the contact's personal description
  • the other one to clear the personal description.

Both services will be needed for the new UI.

@djaiss
Copy link
Member Author

djaiss commented Feb 12, 2020

@asbiin I need this PR to be implemented tonight so I can move forward with what I want to do for the new UI. These are two really simple services so I think it’s safe that I merge them right away without code review.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@djaiss djaiss merged commit 5e1710c into master Feb 12, 2020
@djaiss djaiss deleted the 2020-02-11-description-service branch February 12, 2020 01:10
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant