Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix markdown not being applied for a phone call description #3537

Merged
merged 3 commits into from
Feb 1, 2020
Merged

fix: fix markdown not being applied for a phone call description #3537

merged 3 commits into from
Feb 1, 2020

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Feb 1, 2020

Close #3388

Result:

image

@djaiss djaiss changed the title 2020 02 01 fix 3388 fix: fix markdown not being applied for a phone call description Feb 1, 2020
@djaiss djaiss requested a review from asbiin February 1, 2020 14:15
asbiin
asbiin approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn't know this could be so easy to fix!

@djaiss
Copy link
Member Author

djaiss commented Feb 1, 2020

Wow, I didn't know this could be so easy to fix!

Yeah I added a long time ago a CSS class that deals with every markdown related.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djaiss djaiss merged commit ad11e47 into master Feb 1, 2020
@djaiss djaiss deleted the 2020-02-01-fix-3388 branch February 1, 2020 17:12
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asbiin asbiin asbiin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The calling texts doesn't show <ul> lists
2 participants
@djaiss @asbiin