Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix VCard export of LinkedIn data #3434

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Conversation

muglug
Copy link

@muglug muglug commented Jan 6, 2020

This was found with the dev-master version of psalm/laravel-plugin (along with the dev-master version of Psalm) which now inspects property names. I'll try to release both in the next day or two!

@muglug muglug changed the title Fix bad variable name Fix VCard export of LinkedIn data Jan 6, 2020
@asbiin asbiin changed the title Fix VCard export of LinkedIn data fix: fix VCard export of LinkedIn data Jan 7, 2020
@asbiin
Copy link
Member

asbiin commented Jan 7, 2020

Thank you @muglug !
I will add some test to complete the PR

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
2.3% 2.3% Duplication

@asbiin asbiin merged commit 7a2e0fb into monicahq:master Jan 8, 2020
@asbiin
Copy link
Member

asbiin commented Jan 8, 2020

Thanks @muglug !!

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants