fix: fix reminders API GET requests #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mechanarchy Thank you! Great catch! |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #2557 . As identified by @vrajroham, the
deliblefield is ofbooltype but it was being decoded as a datetime in the API. I've changed the code so it uses the same type of boolean conversion as other API types.I've also tweaked the
test_reminders_get_all()function intests/Api/ApiReminderControllerTest.phpto ensure thatdelible=Falseis tested - I hope this is acceptable. Before fixing the controller, the test failed (as expected, given the bug reports); after fixing the controller, the test passes and I am also able to get results from the API from an external script.