-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): add fakesmtp #3056
chore(docker): add fakesmtp #3056
Conversation
with docker, we might want to use fakesmtp instead of mailtrap. in the env.dev, replace the following : - MAIL_HOST = fake_mail - MAIL_PORT = 5025 - remember to add a MAIL_FROM_ADDRESS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea.
I prefer to use mailhog/mailhog to do this, it should be quite the same.
As request, this should be handled in a global gitignore
What do you think about |
I tested it, it work fine and the interface is clean, I see no problem using it. |
use mailhog/mailhog instead of gessnerfl/fake-smtp-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea!
This pull request has been automatically locked since there |
When using docker in development , we might want to use fakesmtp instead of mailtrap which require creating an account .
If using it, in the env.dev, replace the following :
First of all thanks so much for taking the time to open a pull request and help the project. It's because of people like you that we love working on this project.
Please read the list below. Feel free to delete this text after but we need you to read it so we make sure that the project is consistent and remains of quality.
Checklist
Before submitting the PR
[wip]
in the title of the PR it is is not final yet. Remove[wip]
when ready. Otherwise the PR will be considered complete and rejected if it's not working.General checks
Front-end changes
Backend/models changes
If the code changes the SQL schema
vCard
and.csv
files.Other tasks
UNRELEASED
.