Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): add fakesmtp #3056

Merged
merged 4 commits into from
Oct 22, 2019
Merged

chore(docker): add fakesmtp #3056

merged 4 commits into from
Oct 22, 2019

Conversation

sylvainmetayer
Copy link
Contributor

@sylvainmetayer sylvainmetayer commented Oct 1, 2019

When using docker in development , we might want to use fakesmtp instead of mailtrap which require creating an account .

If using it, in the env.dev, replace the following :

  • MAIL_HOST = fake_mail
  • MAIL_PORT = 1025
  • remember to add a MAIL_FROM_ADDRESS

First of all thanks so much for taking the time to open a pull request and help the project. It's because of people like you that we love working on this project.

Please read the list below. Feel free to delete this text after but we need you to read it so we make sure that the project is consistent and remains of quality.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging @djaiss or @asbiin in this PR.
  • Screenshots are included if the PR changes the UI.
  • Front-end tests have been written with Cypress.

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the FakeContentTableSeeder is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • Make sure exporting account data as SQL is still working.
  • Make sure your changes do not break importing data with vCard and .csv files.
  • Make sure account reset and deletion still work.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

with docker, we might want to use fakesmtp instead of mailtrap.

in the env.dev, replace the following :

- MAIL_HOST = fake_mail
- MAIL_PORT = 5025
- remember to add a MAIL_FROM_ADDRESS
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea.
I prefer to use mailhog/mailhog to do this, it should be quite the same.

.gitignore Outdated Show resolved Hide resolved
As request, this should be handled in a global gitignore
@sylvainmetayer sylvainmetayer requested a review from asbiin October 19, 2019 14:20
@asbiin
Copy link
Member

asbiin commented Oct 20, 2019

What do you think about mailhog/mailhog image instead?

@sylvainmetayer
Copy link
Contributor Author

I tested it, it work fine and the interface is clean, I see no problem using it.

sylvainmetayer and others added 2 commits October 22, 2019 08:05
use mailhog/mailhog instead of gessnerfl/fake-smtp-server
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

@asbiin asbiin merged commit 2e5508f into monicahq:master Oct 22, 2019
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants