Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct link for deceased flag in archived contacts list #2834

Conversation

vladimino
Copy link

Resolves #2522.

My first contribution here, yay! 🎉

I didn't find any related tests and locally the whole test suite is passing, let me know if you would like me to add something for this URL check.

Thanks,
Vlad

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2019

CLA assistant check
All committers have signed the CLA.

@vladimino
Copy link
Author

@djaiss @asbiin can I have your eye on that?

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code!

@asbiin
Copy link
Member

asbiin commented Jul 30, 2019

@vladimino Thank you! Nothing to add, this looks good to me. I will merge it as soon as possible.

@asbiin asbiin merged commit 90e8fb6 into monicahq:master Aug 2, 2019
@vladimino vladimino deleted the fix/correct-link-for-deceased-flag-in-archived-contacts-list branch August 4, 2019 19:13
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Archived contact page links to normal contacts for tag selection and showing deceased people
3 participants