fix: fix reminders not being sent #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @djaiss. |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the problem that reminders are not being sent is because the job
NotifyUserAboutRemindertakes a ReminderOutbox object in parameter and triggers the different notifications to be sent by also passing the same ReminderOutbox object to the other jobs.However
NotifyUserAboutReminderalso deletes the current ReminderOutbox object at the end of the function. Therefore once the other jobs want to process their queues, they can't find the ReminderOutbox object as it has been deleted by the parent job.I suppose that we haven't seen this behaviour locally because queues are synchronous, whereas they are asynchronous in production.