fix: switch to HTTPS schema early #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using nginx as a https termination reverse proxy the assets and URL in the html were generated as HTTP causing the browser not to trust them, especially the login form. This fixes the issue by switching to HTTPS early in the app startup allowing laravel to generate URLs to have the HTTPS schema. Issue monicahq#835
|
|
When using nginx as a https termination reverse proxy the assets and URL in the html were generated as HTTP causing the browser not to trust them, especially the login form. This fixes the issue by switching to HTTPS early in the app startup allowing laravel to generate URLs to have the HTTPS schema. Issue monicahq#835
|
Thank you @FranPregernik ! |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using nginx as a https termination reverse proxy the assets and
URL in the html were generated as HTTP causing the browser not to
trust them, especially the login form.
This fixes the issue by switching to HTTPS early in the app startup
allowing laravel to generate URLs to have the HTTPS schema.
Issue #835