Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change how linkedin information is stored #2200

Merged
merged 6 commits into from
Dec 25, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Dec 25, 2018

This PR changes how LinkedIn url is stored on the Contact object.

Previously it was stored as the linkedin_url field on the Contact object. I've now added LinkedIn as a contact field type in the instance.

That means the linkedin info has been moved to a contact field instead. The API has also been updated (and it's a breaking change).

This PR continues the work of migrating the work information out of the Contact object.

@djaiss djaiss merged commit acfb216 into master Dec 25, 2018
@djaiss djaiss deleted the 2018-12-24-migrate-linkedin-url branch January 5, 2019 20:22
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants