-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add weather support #2178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes to made ...
Co-Authored-By: djaiss <djaiss@users.noreply.github.com>
I've change the darksky call to use SI units, to save temperature in database in celsius. We should only have standards units in our database, and convert it to odd units afterwards. |
@asbiin awesome, thanks for the review and for the help! |
…monica into 2018-11-03-add-weather-support
This pull request has been automatically locked since there |
This PR adds support for weather.
ENABLE_WEATHER
andDARKSKY_API_KEY
to enable this service.Things that remain to be done
The information is displayed on the left side of the profile page.