Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor contact management with services #2168

Merged
merged 23 commits into from
Dec 21, 2018
Merged

chore: refactor contact management with services #2168

merged 23 commits into from
Dec 21, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Dec 18, 2018 •
edited
Loading

This PR refactors how contacts are created/updated/deleted using services.

Todo:

  • Put back new ResizeAvatars to Create/Update service
  • Delete avatars when deleting a contact
  • Changelog

@djaiss
Copy link
Member Author

djaiss commented Dec 19, 2018

@asbiin do you know why circleci fails here?

sonarqubecloud[bot]
sonarqubecloud bot reviewed Dec 20, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 23

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)
  2. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)
  3. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)

See all issues in SonarCloud

sonarqubecloud[bot]
sonarqubecloud bot reviewed Dec 21, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 13

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)
  2. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)
  3. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)

See all issues in SonarCloud

sonarqubecloud[bot]
sonarqubecloud bot reviewed Dec 21, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 13

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)
  2. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)
  3. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)

See all issues in SonarCloud

sonarqubecloud[bot]
sonarqubecloud bot reviewed Dec 21, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 8

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)

See all issues in SonarCloud

sonarqubecloud[bot]
sonarqubecloud bot reviewed Dec 21, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 8

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: 1 duplicated blocks of code must be removed. (more)

See all issues in SonarCloud

sonarqubecloud[bot]
sonarqubecloud bot reviewed Dec 21, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 2

See all issues in SonarCloud

@djaiss djaiss merged commit d242e0f into master Dec 21, 2018
@djaiss djaiss deleted the 2018-12-18-add-contact-services branch December 23, 2018 18:41
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonarqubecloud sonarqubecloud[bot] sonarqubecloud[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djaiss