feat: add a service that geocodes addresses #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com:monicahq/monica into 2018-12-16-automatically-get-gps-coordinates
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2160
This PR adds a service which automatically translates an address to latitude/longitude coordinates.
It also introduces two new ENV variables:
ENABLE_GEOLOCATIONandLOCATION_IQ_API_KEY.The service returns null if one of those two variables are set to null or empty.
It uses LocationIQ as the backend for this. I don't want to use any Google services if we can avoid it. LocationIQ allows 10 000 free calls per day.
Once we have this service in place, we'll be able to finally get weather data from addresses.
Remains to be done: