fix: reduce the number of queries in the dashboard by eager loading the contacts #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
That is awesome ❤️ I love those optimizations. |
asbiin
approved these changes
Dec 10, 2018
|
You're welcome! However, before merging, be aware that I added a new commit that reduces the number of queries even more for partial contacts (41 queries now on the same installation, 120ms) |
|
Thank you very much @AdrienPoupa ! |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request eager loads the contacts for the reminders in the dashboard, in
getRemindersForMonthSince contacts are accessed several times from the _monthReminder view, load them from the beginning.
On my installation, adding the with line does the following:
As a bonus, if I had not any partial contact, the number of queries would drop to 27, 84ms and 6.60Mb