Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add asset tags to resources so they load properly in non-root directories #2115

Merged
merged 7 commits into from
Nov 30, 2018

Conversation

bendauphinee
Copy link

Other tasks

CHANGELOG entry added, if necessary, under UNRELEASED.
CONTRIBUTORS entry added, if necessary.

I plan to make an entry once I've got more of this fixed. I wanted to get this small PR in first to make sure I've got it right about contributing.

(Partially) Fixes #139

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your help!

resources/views/marketing/auth.blade.php Outdated Show resolved Hide resolved
@bendauphinee
Copy link
Author

Fixed PR. Bad edit at 3AM on that one :D

@bendauphinee
Copy link
Author

@asbiin I flagged the review as resolved, but it's still showing as changes requested and I'm not sure how to resolve that, or if I need to. This is updated and should be clean now.

@djaiss djaiss changed the title fix: added asset tags to resources so they load properly in non-root directories fix: add asset tags to resources so they load properly in non-root directories Nov 28, 2018
@bendauphinee
Copy link
Author

@djaiss Is it usual for Jenkins to be broken? I take it it's broken because it's been hours and not completed.

@asbiin asbiin merged commit 46ad5f1 into monicahq:master Nov 30, 2018
@asbiin
Copy link
Member

asbiin commented Nov 30, 2018

@bendauphinee Thank you!

@bkanuka
Copy link

bkanuka commented Dec 31, 2018

Some resources are still missing asset tags. For example, line 12 in verify.blade.php

I'll attempt an MR but I've never used php/blade.

@bendauphinee
Copy link
Author

@bkanuka Yes, a lot of pages are still missing asset tags. I have most of the modifications, just been busy with holiday stuff. Feel free to PR them if you want to.

@bkanuka
Copy link

bkanuka commented Dec 31, 2018

I've fixed a lot of the asset tags too, but I can't get past the registration to test. When I first start monica, I create the new user and then get redirected to http://localhost/register rather than http://localhost/monica/register. Fixing this is going to require more PHP knowledge than I have unfortunately...

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Want To Install In Sub Directory 📁
4 participants