-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add asset tags to resources so they load properly in non-root directories #2115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your help!
…nto feature/href_fixes
Fixed PR. Bad edit at 3AM on that one :D |
@asbiin I flagged the review as resolved, but it's still showing as changes requested and I'm not sure how to resolve that, or if I need to. This is updated and should be clean now. |
@djaiss Is it usual for Jenkins to be broken? I take it it's broken because it's been hours and not completed. |
@bendauphinee Thank you! |
Some resources are still missing asset tags. For example, line 12 in verify.blade.php I'll attempt an MR but I've never used php/blade. |
@bkanuka Yes, a lot of pages are still missing asset tags. I have most of the modifications, just been busy with holiday stuff. Feel free to PR them if you want to. |
I've fixed a lot of the asset tags too, but I can't get past the registration to test. When I first start monica, I create the new user and then get redirected to |
This pull request has been automatically locked since there |
Other tasks
I plan to make an entry once I've got more of this fixed. I wanted to get this small PR in first to make sure I've got it right about contributing.
(Partially) Fixes #139