Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix VCard import without firstname #2093

Merged
merged 8 commits into from
Nov 29, 2018
Merged

fix: fix VCard import without firstname #2093

merged 8 commits into from
Nov 29, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Nov 24, 2018

When a VCard only has one name, like

FN:Mike
N:Mike;;;;

the preg_split function used was not use well.

This fix #2085

@asbiin asbiin mentioned this pull request Nov 26, 2018
@asbiin
Copy link
Member Author

asbiin commented Nov 26, 2018

Just need to write a test for this.

@asbiin asbiin merged commit 3ea2654 into master Nov 29, 2018
@asbiin asbiin deleted the fix/vcard-import branch November 29, 2018 21:01
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Importing vCards
2 participants