Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to create tasks that are not linked to contacts [wip] #2067

Merged
merged 18 commits into from
Nov 18, 2018
Merged

feat: add ability to create tasks that are not linked to contacts [wip] #2067

merged 18 commits into from
Nov 18, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Nov 17, 2018 •
edited
Loading

This PR lets users add tasks that are not associated with contacts. Users can now add tasks straight from the dashboard.

This PR also

  • creates new services to manage tasks
  • rewrite all unit tests about tasks
  • remove unused images from the dashboard

@djaiss djaiss changed the title feat: add ability to create tasks that are not linked to contacts feat: add ability to create tasks that are not linked to contacts [wip] Nov 17, 2018
@djaiss
Copy link
Member Author

djaiss commented Nov 17, 2018 •
edited
Loading

Remains to be done:

  • Rewrite how tasks are managed on the contact page (this is now broken)
  • Use filters in Vue on the dashboard

sonarqubecloud[bot]
sonarqubecloud bot reviewed Nov 18, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

sonarqubecloud[bot]
sonarqubecloud bot reviewed Nov 18, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

@djaiss djaiss merged commit 4f3fbd9 into master Nov 18, 2018
@djaiss djaiss deleted the 2018-11-15-note-without-contact branch November 21, 2018 02:05
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonarqubecloud sonarqubecloud[bot] sonarqubecloud[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djaiss