Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incompatibility with PostgreSQL in people search #2055

Merged
merged 6 commits into from
Nov 30, 2018

Conversation

LorenzoAncora
Copy link

The search query used the comparison operator in a non-standard way. [...] [see commit 04a5c19]

The search query used the comparison operator in a non-standard way, incompatible with PostgreSQL (HTTP error 500 in people/search). PostgreSQL does not do the implicit casting from integer to boolean, you must explicitly write TRUE/FALSE (recommended) or implement explicit casting (not ideal with frequent queries).
@djaiss
Copy link
Member

djaiss commented Nov 28, 2018

Thanks @LorenzoAncora for your help!

@LorenzoAncora
Copy link
Author

@djaiss you're welcome. Can you merge this pull request manually? I am having problems because the automatic checks are too slow and every time I must do a new merge. I do not know if this process will ever end ... :-)

@asbiin asbiin merged commit 0f076f9 into monicahq:master Nov 30, 2018
@asbiin
Copy link
Member

asbiin commented Nov 30, 2018

@LorenzoAncora thank you!

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants