-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vcard services for import/export #1996
Conversation
…hq/monica into feat/vcard-import-export-services
…hq/monica into feat/vcard-import-export-services
…hq/monica into feat/vcard-import-export-services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 1
Vulnerabilities: 0
Code Smells: 4
Including the following issue(s) which could not be reported in line:
- Code Smell: Remove the unused function parameter "$request". (more)
…hq/monica into feat/vcard-import-export-services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Lots and lots of work.
I've tested the import locally and it works. One of our user's huge file (40mb) still doesn't work though, even with this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…hq/monica into feat/vcard-import-export-services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been automatically locked since there |
No description provided.