fix: fix activity buttons spacing #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The activity buttons broke off into two lines because of the width and the icons was spaced a little weird.
|
|
asbiin
requested changes
Oct 28, 2018
Co-Authored-By: andreasjacobsen93 <andreasjacobsen93@gmail.com>
asbiin
requested changes
Nov 2, 2018
|
@andreasjacobsen93 still need to change layout for LTR/RTL. What do you think ? |
Co-Authored-By: andreasjacobsen93 <andreasjacobsen93@gmail.com>
|
I think the last change makes sense.. still need to test it tho |
asbiin
approved these changes
Nov 11, 2018
|
@andreasjacobsen93 thank you! |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The activity buttons broke off into two lines because of the width and the icons was spaced a little weird.
The button now looks as below, which I think is a little nicer.
