-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add api tests #1928
test: add api tests #1928
Conversation
… tests/add-api-tests
… tests/add-api-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -288,6 +288,7 @@ public function respondNotTheRightParameters($message = 'Too many parameters') | |||
*/ | |||
public function respondWithError($message) | |||
{ | |||
// TODO status code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Smell: Complete the task associated to this "TODO" comment. (php:S1135)
… tests/add-api-tests
Wow. That's a huge increase!! |
This pull request has been automatically locked since there |
Add some tests for api
code coverage (global): from 54.0% to 61.6%