Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add api tests #1928

Merged
merged 20 commits into from
Oct 21, 2018
Merged

test: add api tests #1928

merged 20 commits into from
Oct 21, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Oct 19, 2018

Add some tests for api

code coverage (global): from 54.0% to 61.6%

@asbiin asbiin changed the title tests: add api tests test: add api tests Oct 20, 2018
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

@@ -288,6 +288,7 @@ public function respondNotTheRightParameters($message = 'Too many parameters')
*/
public function respondWithError($message)
{
// TODO status code

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Complete the task associated to this "TODO" comment. (php:S1135)

See it in SonarCloud

@asbiin asbiin merged commit 511b842 into master Oct 21, 2018
@asbiin asbiin deleted the tests/add-api-tests branch October 21, 2018 20:46
@djaiss
Copy link
Member

djaiss commented Oct 22, 2018

Wow. That's a huge increase!!

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants