fix: do not send confirm email when signup_double_optin is false #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaiss
reviewed
Sep 10, 2018
app/Services/User/EmailChange.php
Outdated
| throw new MissingParameterException('Missing parameters'); | ||
| } | ||
|
|
||
| $user = auth()->user(); |
There was a problem hiding this comment.
I don't think it's a good idea that you use auth()->user() in a service. This assumes that we call the service in the context where we are authenticated which might not be always the case.
Instead, you need to pass the user id as a parameter and then find the user, etc...
More DB queries but at least, the service is not dependant on something else.
Yes that was my intention ;) |
|
@djaiss tests done! |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.