Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update mail template #1768

Merged
merged 27 commits into from
Sep 18, 2018
Merged

feat: update mail template #1768

merged 27 commits into from
Sep 18, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Sep 2, 2018 •
edited
Loading

Example:
image

This fix #1339 and will close #1767

@djaiss
Copy link
Member

djaiss commented Sep 2, 2018

Excellent. It doesn't "fix" #1339 though - just partially. We should apply this to the reminder themselves, not only the stay in touch, if we want to close #1339.

@asbiin
Copy link
Member Author

asbiin commented Sep 2, 2018

@djaiss indeed. I've rewrite the other reminders, but we can certainly go further.

@asbiin asbiin changed the title feat: update mail template feat: update mail template [wip] Sep 3, 2018
sonarqubecloud[bot]
sonarqubecloud bot reviewed Sep 4, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

sonarqubecloud[bot]
sonarqubecloud bot reviewed Sep 4, 2018
View reviewed changes
Copy link

@sonarqubecloud sonarqubecloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

@asbiin asbiin changed the title feat: update mail template [wip] feat: update mail template Sep 5, 2018
@asbiin asbiin requested a review from djaiss September 6, 2018 20:43
@asbiin
Copy link
Member Author

asbiin commented Sep 11, 2018

@djaiss can you review this please?

@asbiin asbiin merged commit 4259d5f into master Sep 18, 2018
@asbiin asbiin deleted the feat/refactor-mails-template branch October 12, 2018 00:10
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonarqubecloud sonarqubecloud[bot] sonarqubecloud[bot] left review comments

@djaiss djaiss Awaiting requested review from djaiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email reminders are very shouty
3 participants
@asbiin @djaiss @MonicaBot