feat: Get first existing gravatar of all emails of the contact #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaiss
requested changes
Aug 15, 2018
app/Models/Contact/Contact.php
Outdated
| * | ||
| * @param int $size | ||
| * @return string|bool | ||
| */ | ||
| public function getGravatar($size) | ||
| { | ||
| $email = $this->getFirstEmail(); | ||
| $emails = $this->contactFields() |
There was a problem hiding this comment.
This is basically the content of getFirstEmail method.
This method is now not used anywhere in the app.
There was a problem hiding this comment.
Indeed. Do you wish to remove it?
djaiss
approved these changes
Aug 15, 2018
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to get gravatar, not for the first email, but for every emails: first gravatar detected is returned.