-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converted columns for emoji support #169
Conversation
app/Providers/AppServiceProvider.php
Outdated
@@ -17,6 +18,9 @@ public function boot() | |||
View::composer( | |||
'partials.components.country-select','App\Http\ViewComposers\CountrySelectViewComposer' | |||
); | |||
|
|||
Schema::defaultStringLength(191); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that? There are some places in the code where we wanted to limit the number of characters in an input field to 255 characters. If we put this, does that mean that the default VARCHAR is limited to 191?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its for backward compatibility for older versions of mysql. Very common problem when deploying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looking through some PRs and noticed this one.
What would happen to the installs of Monica that have a varchar-field that have values of 192 characters or longer? Truncated data is not so fun.
If breaking changes is fine, just forcing users to enable innodb_large_prefix
on the older MySQL-installs would be a much more elegant solution and wouldn't cause any data loss.
This looks useful and necessary, I once faced the same issue. |
|
…feature/emoji-support
OK this PR finally works for me. |
This pull request has been automatically locked since there |
Fixes #168
This was a little bit involved and touches every text based column, table and schema.
Links to help me along the way are below: