Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog inside the application #1172

Merged
merged 15 commits into from
Apr 14, 2018
Merged

Add changelog inside the application #1172

merged 15 commits into from
Apr 14, 2018

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Apr 14, 2018

This PR adds a "What's new" section inside the product, so users can discover the new features as we introduce them.

Code-related tasks

  • Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant, add the documentation about your feature in the README file.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

@djaiss djaiss self-assigned this Apr 14, 2018
@djaiss djaiss added this to the 2.0.1 milestone Apr 14, 2018
@codecov
Copy link

codecov bot commented Apr 14, 2018

Codecov Report

Merging #1172 into master will increase coverage by 0.3%.
The diff coverage is 83.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #1172     +/-   ##
==========================================
+ Coverage        40%   40.3%   +0.3%     
  Complexity       11      11             
==========================================
  Files           200     203      +3     
  Lines          5234    5264     +30     
==========================================
+ Hits           2093    2118     +25     
- Misses         3141    3146      +5
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/ChangelogController.php 0% <0%> (ø) 0 <0> (?)
app/Http/Controllers/SettingsController.php 11.7% <0%> (ø) 0 <0> (ø) ⬇️
app/Instance.php 57.2% <100%> (+57.2%) 0 <0> (ø) ⬇️
app/Account.php 88.9% <100%> (+0.2%) 0 <0> (ø) ⬇️
app/Changelog.php 100% <100%> (ø) 0 <0> (?)
app/User.php 100% <100%> (ø) 0 <0> (ø) ⬇️
app/Jobs/AddChangelogEntry.php 100% <100%> (ø) 0 <0> (?)
app/Reminder.php 98% <0%> (-2%) 0% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3fe20...68d57e1. Read the comment docs.

@djaiss djaiss changed the title Add changelog inside the application [wip] Add changelog inside the application Apr 14, 2018
@djaiss djaiss merged commit ad2b75d into master Apr 14, 2018
@djaiss djaiss deleted the 2018-04-13-change-system branch April 15, 2018 01:17
@@ -0,0 +1 @@
[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be deleted

height: 9px;
pointer-events: none;
top: 16px;
left: 17px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have a side effect on RTL languages

@asbiin
Copy link
Member

asbiin commented Apr 15, 2018

Nice work !

@djaiss djaiss mentioned this pull request Apr 16, 2018
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants