Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get list of countries from countries-laravel package #1117

Merged
merged 33 commits into from
May 8, 2018
Merged

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Apr 8, 2018

This will close #852

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Make sure that the change you propose is the smallest possible.
  • Screenshots are included if the PR changes the UI.
  • If you change the UI, make sure the user experience is consistent with the current interface.

Code-related tasks

  • Tests added for this feature/bug.
  • Impact on the seeders.
  • Impact on the API.

If the code changes the SQL schema

  • Impact on account export.
  • Impact on importing data with vCard and .csv files.
  • Impact on account reset and deletion.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant, add the documentation about your feature in the README file.
  • Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

@monicahq monicahq deleted a comment from codecov bot Apr 25, 2018
@asbiin asbiin temporarily deployed to monica-team-pr-1117 April 25, 2018 21:29 Inactive
@asbiin asbiin changed the title Get list of countries from countries-laravel package [wip] Get list of countries from countries-laravel package Apr 25, 2018
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 2, 2018 08:27 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 7, 2018 17:10 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 7, 2018 17:19 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 7, 2018 17:21 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 8, 2018 10:14 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 8, 2018 11:41 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 8, 2018 14:19 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 8, 2018 15:00 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 8, 2018 15:13 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 8, 2018 15:36 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 8, 2018 15:49 Inactive
@asbiin asbiin temporarily deployed to monica-team-pr-1117 May 8, 2018 16:04 Inactive
@github-actions
Copy link

github-actions bot commented Feb 9, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'countries' database table to export dump
1 participant