Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact deletion #1114

Merged
merged 3 commits into from
Apr 7, 2018
Merged

Fix contact deletion #1114

merged 3 commits into from
Apr 7, 2018

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Apr 7, 2018

Introduced with #971 : this line was missed in the new Contact::deleteEverything function:
https://github.com/monicahq/monica/pull/971/files#diff-da2c468a7e44d4976ad8308dbe22e7faL340

@codecov
Copy link

codecov bot commented Apr 7, 2018

Codecov Report

Merging #1114 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #1114     +/-   ##
==========================================
+ Coverage      38.3%   38.5%   +0.2%     
  Complexity       11      11             
==========================================
  Files           195     195             
  Lines          5173    5174      +1     
==========================================
+ Hits           1979    1988      +9     
+ Misses         3194    3186      -8
Impacted Files Coverage Δ Complexity Δ
app/Contact.php 83% <100%> (+2.2%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2513137...08618c6. Read the comment docs.

@asbiin asbiin merged commit 04607f3 into master Apr 7, 2018
@asbiin asbiin deleted the fix-contact-deletion branch April 7, 2018 14:07
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant