Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirmation to delete a journal entry #4308

Open
asbiin opened this issue Aug 9, 2020 · 2 comments
Open

Add a confirmation to delete a journal entry #4308

asbiin opened this issue Aug 9, 2020 · 2 comments

Comments

@asbiin
Copy link
Member

asbiin commented Aug 9, 2020

Feedback from a user

The "Delete" action for a journal entry is very close to the "Edit" link and you can easily delete a journal entry and lose all of the info as there's no confirmation of the delete action.

We should at least add a confirmation on the delete action.

@TeddyBear06
Copy link

TeddyBear06 commented Sep 6, 2020

Hi @asbiin ,

Do you think that a confirm box like this one https://imgur.com/a/IhJl7Fi can do the job ?

I already edited the trash() method of JournalContentEntry.vue to do so with i18n support.

@asbiin
Copy link
Member Author

asbiin commented Sep 6, 2020

@TeddyBear06 Thank you. That would do the job yes ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants