Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a map to display where our contacts are #391

Open
djaiss opened this issue Jun 25, 2017 · 13 comments
Open

Add a map to display where our contacts are #391

djaiss opened this issue Jun 25, 2017 · 13 comments

Comments

@djaiss
Copy link
Member

djaiss commented Jun 25, 2017

This could be a discreet map button on the people list, in which we could display a map with dots representing our contacts.

@turtles2
Copy link

turtles2 commented Jan 5, 2018

@djaiss How do you propose we get the users locations. I see two ways firstly we could geocode there address but this requires some geocoding API most have limits and restrictions the ones that don't would require us to use our own software and use OpenAddress data which is not complete. The second approach is we could display a map and have the user drop a pin kinda of a manual geocoding. I have experience with both approaches.

@djaiss
Copy link
Member Author

djaiss commented Jan 7, 2018

@turtles2 I think it could be even simpler than this. It's not user location, it's contact location.
We could simply take the address stored per contact, manually entered by the contact.
Can we then display them on a map using Google Maps for instance?

If we can find the easiest way to achieve this, I'll wireframe where I think we should put the map

@turtles2
Copy link

turtles2 commented Jan 7, 2018 via email

@djaiss
Copy link
Member Author

djaiss commented Jan 7, 2018

@turtles2 so OpenAddress then? What is the library for this? Would be MIT?

@turtles2
Copy link

turtles2 commented Jan 7, 2018 via email

@djaiss
Copy link
Member Author

djaiss commented Jan 7, 2018

@turtles2 ouch. 200 Gb. We have to find another solution.
I've taken a look at Google Maps API. For personal use, we don't need to provide payment information up to a reasonable amounts of queries per day. For our .com version, I'd need to provide payment information though.
I think that's the only viable route for now.

@turtles2
Copy link

turtles2 commented Jan 7, 2018 via email

@rogerxaic
Copy link

Hi there,

How about using LeafletJS to display OpenStreetMap maps?
They've also got Nominatim, a geocoding tool.

I don't know though if they've got an open API or if a manual clone+deploy is necessary? Or maybe there's an API but an API KEY is required?

An option could be to have a disabled feature and someone that wants to activate should get an API key and set it up via env vars or the admin panel described in #1876 and #3462.

What do you think?

@djaiss
Copy link
Member Author

djaiss commented Dec 18, 2020

No, the feature should not be enabled/disabled in the Settings panel.

It should be visible in the app if the key is there in the env file, and should be hidden if the key is not there. But we shouldn't have another option in the Settings panel.

Monica already supports geolocation with Location IQ. We just need to find the proper map provider.

@virtadpt
Copy link

@djaiss +1 for Open Streetmap.

@iloveitaly
Copy link

This would be awesome. I think there's already a geocoding function built in, so there shouldn't be a massive lift.

@GetoXs
Copy link

GetoXs commented May 26, 2022

Just want to bump that would be awesome! 💥

@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants