-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a map to display where our contacts are #391
Comments
@djaiss How do you propose we get the users locations. I see two ways firstly we could geocode there address but this requires some geocoding API most have limits and restrictions the ones that don't would require us to use our own software and use OpenAddress data which is not complete. The second approach is we could display a map and have the user drop a pin kinda of a manual geocoding. I have experience with both approaches. |
@turtles2 I think it could be even simpler than this. It's not If we can find the easiest way to achieve this, I'll wireframe where I think we should put the map |
If we are displaying the map on the page my concern is not technical it's
legal as Google has strict rules for the use of there APIs and last time I
did something similar anything behind a log in required a payment for the
API. Now if we are talking about linking to Google maps then we would avoid
that but the user would leave the application. The other approach uses open
data and software to power the maps so there is no thorny legal issues.
On Jan 6, 2018 11:10 PM, "Régis Freyd" <notifications@github.com> wrote:
@turtles2 <https://github.com/turtles2> I think it could be even simpler
than this. It's not user location, it's contact location.
We could simply take the address stored per contact, manually entered by
the contact.
Can we then display them on a map using Google Maps for instance?
If we can find the easiest way to achieve this, I'll wireframe where I
think we should put the map
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#391 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADfAurIfCqUAZEZqIfzIkeCS7QVQtDOoks5tIFHMgaJpZM4OEgNq>
.
|
@turtles2 so OpenAddress then? What is the library for this? Would be MIT? |
Here is the thing with Open Address I am only aware of one service offering
an API and they are shutting down. The code that powers it is all open
source (MIT?) so I will check if someone else is going to pick it up
otherwise it will be difficult as it requires allot of storage space to run
we are talking somewhere around 100 to 200 GB of data. The service is
mapzen by the way.
…On Jan 7, 2018 8:50 AM, "Régis Freyd" ***@***.***> wrote:
@turtles2 <https://github.com/turtles2> so OpenAddress then? What is the
library for this? Would be MIT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADfAuuMyf-VAV-REEktleyBQyq0irB9Yks5tINmngaJpZM4OEgNq>
.
|
@turtles2 ouch. 200 Gb. We have to find another solution. |
I agree with you on that. Why don't you put in a wire frame and we will see
if we can get this done.
…On Jan 7, 2018 10:22 AM, "Régis Freyd" ***@***.***> wrote:
@turtles2 <https://github.com/turtles2> ouch. 200 Gb. We have to find
another solution.
I've taken a look at Google Maps API. For personal use, we don't need to
provide payment information up to a reasonable amounts of queries per day.
For our .com version, I'd need to provide payment information though.
I think that's the only viable route for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#391 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADfAutPuti67wdDCb6MBpDvzm19ctxe8ks5tIO8pgaJpZM4OEgNq>
.
|
Hi there, How about using LeafletJS to display OpenStreetMap maps? I don't know though if they've got an open API or if a manual clone+deploy is necessary? Or maybe there's an API but an API KEY is required? An option could be to have a disabled feature and someone that wants to activate should get an API key and set it up via env vars or the admin panel described in #1876 and #3462. What do you think? |
No, the feature should not be enabled/disabled in the Settings panel. It should be visible in the app if the key is there in the env file, and should be hidden if the key is not there. But we shouldn't have another option in the Settings panel. Monica already supports geolocation with Location IQ. We just need to find the proper map provider. |
@djaiss +1 for Open Streetmap. |
This would be awesome. I think there's already a geocoding function built in, so there shouldn't be a massive lift. |
Just want to bump that would be awesome! 💥 |
🎉 This issue has been resolved in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This could be a discreet map button on the people list, in which we could display a map with dots representing our contacts.
The text was updated successfully, but these errors were encountered: