fix: exclude partials from contact limit (#2058)

app/Models/Account/Account.php

@@ -556,7 +556,7 @@ public function hasLimitations()
      */
     public function hasReachedContactLimit()
     {
-        return $this->contacts->count() >= config('monica.number_of_allowed_contacts_free_account');
+        return $this->contacts()->real()->count() >= config('monica.number_of_allowed_contacts_free_account');
     }
 
     /**

database/factories/ModelFactory.php

@@ -91,6 +91,9 @@
         },
     ];
 });
+$factory->state(App\Models\Contact\Contact::class, 'partial', [
+    'is_partial' => 1,
+]);
 
 $factory->define(App\Models\Contact\Gift::class, function (Faker\Generator $faker) {
     return [

tests/Unit/Models/AccountTest.php

@@ -736,6 +736,15 @@ public function test_account_has_reached_contact_limit_on_free_plan()
             $account->hasReachedContactLimit()
         );
 
+        $partials = factory(Contact::class, 5)->state('partial')->create([
+            'account_id' => $account->id,
+        ]);
+
+        config(['monica.number_of_allowed_contacts_free_account' => 15]);
+
+        $this->assertFalse(
+            $account->hasReachedContactLimit()
+        );
         config(['monica.number_of_allowed_contacts_free_account' => 100]);
 
         $this->assertFalse(