Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

feat: support rtl languages #530

Merged
merged 15 commits into from
May 16, 2023
Merged

feat: support rtl languages #530

merged 15 commits into from
May 16, 2023

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented May 14, 2023

Some rules:

  • every x-axis position modifiers must work with ltr and rtl.
    Basically, all left modifier (ml-, border-l, pl-, ...) must be changed with 's' (start) version: ms-, border-s, ps- etc.
    All right modifier (mr-, border-r, pr- ...) must be changed with 'e' (end) version: me-, border-e, pe- etc.
  • for custom classes, use the .ltr and .rtl class selectors to define multiple flavors
  • use Dropdown instead of select

See
https://tailwindcss.com/docs/top-right-bottom-left#using-logical-properties
https://tailwindcss.com/docs/margin#using-logical-properties
https://tailwindcss.com/docs/padding#using-logical-properties
https://tailwindcss.com/docs/border-width#using-logical-properties
https://tailwindcss.com/docs/border-radius#using-logical-properties

The Toaster is now working on dark mode

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.3% 2.3% Duplication

@asbiin asbiin merged commit 65023ec into main May 16, 2023
@asbiin asbiin deleted the 20230514-rtl branch May 16, 2023 22:00
asbiin added a commit to monicahq/monica that referenced this pull request May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant