This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
feat: implement carddav #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaiss
reviewed
Nov 18, 2022
app/Domains/Contact/Dav/Web/Controllers/Backend/CardDAV/AddressBook.php
Outdated
Show resolved
Hide resolved
app/Domains/Contact/Dav/Web/Controllers/Backend/CardDAV/AddressBookHome.php
Outdated
Show resolved
Hide resolved
app/Domains/Contact/ManageContact/Web/Controllers/ContactController.php
Outdated
Show resolved
Hide resolved
| @@ -10,6 +10,43 @@ class Gender extends Model | |||
| { | |||
| use HasFactory; | |||
|
|
|||
| /** | |||
| * Male type gender. | |||
There was a problem hiding this comment.
For future contributors, I think we should add for every single const defined here, that they are used for the Carddav protocol, so they don't get confused.
There was a problem hiding this comment.
Yes, but I think it should not be used for carddav only
There was a problem hiding this comment.
Which other use cases do we need this?
|
Kudos, SonarCloud Quality Gate passed! |
asbiin
added a commit
to monicahq/monica
that referenced
this pull request
Mar 31, 2023
asbiin
added a commit
to monicahq/monica
that referenced
this pull request
May 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a liiiiitle PR to implement carddav