Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Bug: Date type should be optional, but cannot be nulled #377

Closed
njelich opened this issue Jan 5, 2023 · 2 comments · Fixed by #397
Closed

Bug: Date type should be optional, but cannot be nulled #377

njelich opened this issue Jan 5, 2023 · 2 comments · Fixed by #397

Comments

@njelich
Copy link
Contributor

njelich commented Jan 5, 2023 •
edited
Loading

Screen Shot 2023-01-05 at 14 27 41

Also, the date type field variable is shared between the Create and the Edit modals. These elements should be abstracted better.

Path: Pages > Vault >Contact > ImportantDates > Index.vue
@njelich njelich changed the title Bug: Date type should be option, but cannot be negated Bug: Date type should be optional, but cannot be nulled Jan 5, 2023
@djaiss
Copy link
Member

djaiss commented Jan 5, 2023

🤦
You are right. Might not be the only place also.

djaiss added a commit that referenced this issue Jan 12, 2023
@djaiss
fix: fix important date type cant be null
3cc8dc6 
Close #377
@djaiss djaiss mentioned this issue Jan 12, 2023
Merged
@djaiss
Copy link
Member

djaiss commented Jan 12, 2023

Thanks for the bug report!

djaiss added a commit that referenced this issue Jan 12, 2023
@djaiss
fix: fix important date type cant be null (#397)
f74babb 
Close #377
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix important date type cant be null monicahq/chandler
2 participants
@djaiss @njelich