Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For upstream #4

Closed
wants to merge 2 commits into from
Closed

For upstream #4

wants to merge 2 commits into from

Conversation

jkent
Copy link

@jkent jkent commented Apr 25, 2018

  • Add bssid to results
  • Turn RPC result into an array like RPC.List

@rojer
Copy link
Contributor

rojer commented Apr 25, 2018

makes sense, will integrate

@rojer
Copy link
Contributor

rojer commented Apr 25, 2018

i sent a change to integrate this into our internal repo. once it lands, this PR will be automatically closed and once the change is published you will see a commit attached to it.
thanks!

@cpq cpq closed this Apr 25, 2018
cesantabot pushed a commit that referenced this pull request Apr 25, 2018
@cesantabot
Add BSSID to results, change result to array
5262e10 
Closes #4

CL: rpc-service-wifi: Add BSSID to Wifi.Scan results, change result to array

PUBLISHED_FROM=5bd2d57a3ca0373614e33df2f8fc810491e5213e
@jkent
Copy link
Author

jkent commented Apr 26, 2018

One small note; you looked over the changes to the Readme.md !

@rojer
Copy link
Contributor

rojer commented Apr 26, 2018

indeed. i sent a followup.

cesantabot pushed a commit that referenced this pull request Apr 26, 2018
@cesantabot
Update rpc-service-wifi doc
4226010 
Leftover from #4

PUBLISHED_FROM=7c5c336641d1a57aaa396ccc0eab39990590c8b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkent @rojer