Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fail_level to inputs #77

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Add fail_level to inputs #77

merged 1 commit into from
Dec 24, 2024

Conversation

ichizok
Copy link
Contributor

@ichizok ichizok commented Dec 24, 2024

Add fail_level and make fail_on_error deprecated.

@ichizok ichizok requested a review from mongolyy as a code owner December 24, 2024 09:40
@mongolyy
Copy link
Owner

Thank you for your contributing.

I understand that -fail-on-error option is deperecated at v0.20.2.
https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md#rotating_light-deprecation-warnings

@mongolyy mongolyy merged commit 3bb9e69 into mongolyy:main Dec 24, 2024
9 checks passed
@mongolyy
Copy link
Owner

I created v1.7.0-beta for testing.
https://github.com/mongolyy/reviewdog-action-biome/releases/tag/v1.7.0-beta

Once I have confirmed that there are no problems, I'll release v1.7.0.

@ichizok ichizok deleted the feature/fail-level branch December 24, 2024 14:08
@mongolyy
Copy link
Owner

mongolyy commented Jan 6, 2025

@ichizok
Thank you for your contribution. 👏

I apologize for the delay. 🙇
We have officially released your modified version as v1.8.0!! 🎉

@yamcodes yamcodes mentioned this pull request Jan 7, 2025
Closed
@mongolyy mongolyy mentioned this pull request Jan 7, 2025
Merged
@mongolyy
Copy link
Owner

mongolyy commented Jan 7, 2025

Due to the issue in #79, I partially reverted the changes in #80.
I created #81 because the default value of fail_on_error should be removed.

@mongolyy
Copy link
Owner

I created #81 because the default value of fail_on_error should be removed.

My opinion has changed.
I have come to the conclusion that the default value of fail_on_error should be left as it is.

For more details, see the #81 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mongolyy mongolyy mongolyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichizok @mongolyy