Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NODE-6765): sync types for findOneAndUpdate #4423

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

forivall
Copy link

@forivall forivall commented Feb 19, 2025

Description

What is changing?

In #3953, the aggregation pipeline signature was added for updateOne and updateMany, but this was missed for findOneAndUpdate

Is there new documentation needed for these changes?

Documentation is included.

What is the motivation for this change?

The documentation was missing from the node.js driver. The initial motivation is that the downstream mongoose type also need to be updated to allow aggregation pipelines in findOneAndUpdate, but for consistency, these types should be updated first, or at least have this update ready while updating the mongoose types.

https://jira.mongodb.org/browse/NODE-6765

Release Highlight

I don't think this needs a release highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@forivall forivall requested a review from a team as a code owner February 19, 2025 03:42
@dariakp dariakp added tracked-in-jira Ticket filed in MongoDB's Jira system External Submission PR submitted from outside the team labels Feb 19, 2025
@baileympearson baileympearson self-assigned this Feb 19, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 19, 2025
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Submission PR submitted from outside the team Team Review Needs review from team tracked-in-jira Ticket filed in MongoDB's Jira system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants