Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-6524): consolidate socket timeout calculation #4320

Merged
merged 3 commits into from
Nov 12, 2024
Merged

refactor(NODE-6524): consolidate socket timeout calculation #4320

merged 3 commits into from
Nov 12, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Nov 7, 2024 •
edited by nbbeeken
Loading

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title remove dead code perf(NODE-6524): consolidate socket timeout calculation Nov 8, 2024
@baileympearson baileympearson force-pushed the CSOT-perf-improvement-POC branch from 3ee3eaf to 76f04c1 Compare November 8, 2024 21:41
addaleax
addaleax previously approved these changes Nov 10, 2024
View reviewed changes
@baileympearson baileympearson marked this pull request as ready for review November 11, 2024 16:07
nbbeeken
nbbeeken requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reached out on slack for more info; Not seeing a change in perf, but happy to take this in as a refactor for the code clean up

@baileympearson baileympearson changed the title perf(NODE-6524): consolidate socket timeout calculation refactor(NODE-6524): consolidate socket timeout calculation Nov 12, 2024
@nbbeeken nbbeeken merged commit 20564f7 into main Nov 12, 2024
27 of 29 checks passed
@nbbeeken nbbeeken deleted the CSOT-perf-improvement-POC branch November 12, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@addaleax addaleax addaleax left review comments

Assignees

@nbbeeken nbbeeken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @addaleax @nbbeeken