refactor: replace symbol properties in cursor classes

[nbbeeken]

Description

What is changing?

• AbstractCursor
  • Removed all symbol properties in favor of equivalently named strings.
  • Changed "options" to cursorOptions, no need for the getter indirection
  • Added is in front of booleans that have getters
• FindCursor
  • kFilter -> cursorFilter since there is a "filter" method
  • builtOptions -> findOptions, I think the naming came from TS translation days, it is true that the options are built from all the helpers (if one uses those) but in the end they are options for find
• AggregationCursor
  • pipline is a public readonly property which is equivalent to the getter that fetched the symbol property before
• ChangeStreamCursor
  • No symbol properties here, but the "options" property shared the same name as AbstractCursor's "options" until I changed it to "cursorOptions".
  • But that led me to take a look at the class properties, we never set resumeAfter/startAfter on the class, thos remain on the options, unless I missed something.

patch

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Symbol properties served as "private" before we had typescript. We prefer using plain string properties now for better DX, and testing internals.

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[nbbeeken]

evergreen patch

test failures