Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-5043): assert MongoClients are garbage collectable #3561

Merged
merged 9 commits into from
Feb 13, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 8, 2023

Description

What is changing?

Backport of
#3553

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 8, 2023
@dariakp dariakp added the Blocked Blocked on other work label Feb 10, 2023
@dariakp
Copy link
Contributor

dariakp commented Feb 10, 2023

Marking blocked pending review of #3553

@dariakp dariakp added wip and removed Blocked Blocked on other work labels Feb 10, 2023
@nbbeeken nbbeeken removed the wip label Feb 10, 2023
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 10, 2023
@dariakp dariakp merged commit ed5182a into 4.x Feb 13, 2023
@dariakp dariakp deleted the NODE-5028-add-leak-repro-4.x branch February 13, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants