Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-3860): improve skipReason reporting for disabled 'auth' tests #3137

Merged
merged 9 commits into from
Feb 10, 2022
Merged

test(NODE-3860): improve skipReason reporting for disabled 'auth' tests #3137

merged 9 commits into from
Feb 10, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Feb 8, 2022 •
edited
Loading

Description

What is changing?

This PR cleans up the skipReason logic added in #3121. By including the skipReason and the filter status auth: disabled in the metadata for tests that fail because auth was enabled, in cases where the test would not have run due to other requirements, we report the skip reason being that auth was enabled rather than the actual skip reason for the test.

This PR also fixes the broken AWS tests.

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-3860-remove-metadata-skip-reason branch from 9970a7b to ed88651 Compare February 9, 2022 19:55
dariakp
dariakp reviewed Feb 9, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but what do we think of dropping the leading instance of test in testSkipBrokenAuthTestBeforeEachHook and just making it skipBrokenAuthTestBeforeEachHook ?

@baileympearson baileympearson marked this pull request as ready for review February 10, 2022 14:52
nbbeeken
nbbeeken approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty!

@nbbeeken nbbeeken changed the title fix(NODE-3860): Improve skipReason reporting for disabled 'auth' tests test(NODE-3860): improve skipReason reporting for disabled 'auth' tests Feb 10, 2022
@nbbeeken nbbeeken merged commit 9242de5 into main Feb 10, 2022
@nbbeeken nbbeeken deleted the NODE-3860-remove-metadata-skip-reason branch February 10, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @nbbeeken @dariakp