test(aggregation): ensure deterministic order for these tests

These tests check the values of the results in an presumed order, but in sharded environment this cannot be guaranteed. We should include a `$sort` stage to ensure the ordering.
mongodb · Feb 23, 2019 · d8aed2b · d8aed2b
1 parent 1521397
commit d8aed2b
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 32 deletions.
diff --git a/test/functional/aggregation_tests.js b/test/functional/aggregation_tests.js
@@ -71,7 +71,8 @@ describe('Aggregation', function() {
                   _id: { tags: '$tags' },
                   authors: { $addToSet: '$author' }
                 }
-              }
+              },
+              { $sort: { _id: -1 } }
             ],
             function(err, cursor) {
               expect(err).to.be.null;
@@ -190,19 +191,22 @@ describe('Aggregation', function() {
           // Execute aggregate, notice the pipeline is expressed as function call parameters
           // instead of an Array.
           collection.aggregate(
-            {
-              $project: {
-                author: 1,
-                tags: 1
-              }
-            },
-            { $unwind: '$tags' },
-            {
-              $group: {
-                _id: { tags: '$tags' },
-                authors: { $addToSet: '$author' }
-              }
-            },
+            [
+              {
+                $project: {
+                  author: 1,
+                  tags: 1
+                }
+              },
+              { $unwind: '$tags' },
+              {
+                $group: {
+                  _id: { tags: '$tags' },
+                  authors: { $addToSet: '$author' }
+                }
+              },
+              { $sort: { _id: -1 } }
+            ],
             function(err, cursor) {
               expect(err).to.be.null;
 
@@ -283,19 +287,22 @@ describe('Aggregation', function() {
           // Execute aggregate, notice the pipeline is expressed as function call parameters
           // instead of an Array.
           collection.aggregate(
-            {
-              $project: {
-                author: 1,
-                tags: 1
-              }
-            },
-            { $unwind: '$tags' },
-            {
-              $group: {
-                _id: { tags: '$tags' },
-                authors: { $addToSet: '$author' }
-              }
-            },
+            [
+              {
+                $project: {
+                  author: 1,
+                  tags: 1
+                }
+              },
+              { $unwind: '$tags' },
+              {
+                $group: {
+                  _id: { tags: '$tags' },
+                  authors: { $addToSet: '$author' }
+                }
+              },
+              { $sort: { _id: -1 } }
+            ],
             function(err, cursor) {
               expect(err).to.be.null;
 
@@ -561,7 +568,8 @@ describe('Aggregation', function() {
                   _id: { tags: '$tags' },
                   authors: { $addToSet: '$author' }
                 }
-              }
+              },
+              { $sort: { _id: -1 } }
             ],
             {
               cursor: { batchSize: 1 }
@@ -747,7 +755,8 @@ describe('Aggregation', function() {
                   _id: { tags: '$tags' },
                   authors: { $addToSet: '$author' }
                 }
-              }
+              },
+              { $sort: { _id: -1 } }
             ],
             {
               allowDiskUse: true
@@ -1105,7 +1114,8 @@ describe('Aggregation', function() {
                     _id: { tags: '$tags' },
                     authors: { $addToSet: '$author' }
                   }
-                }
+                },
+                { $sort: { _id: -1 } }
               ],
               {
                 cursor: { batchSize: 1 },

diff --git a/test/functional/operation_example_tests.js b/test/functional/operation_example_tests.js
@@ -87,7 +87,8 @@ describe('Operation Examples', function() {
                   _id: { tags: '$tags' },
                   authors: { $addToSet: '$author' }
                 }
-              }
+              },
+              { $sort: { _id: -1 } }
             ],
             function(err, cursor) {
               test.equal(null, err);
@@ -190,8 +191,8 @@ describe('Operation Examples', function() {
           cursor.toArray(function(err, docs) {
             test.equal(null, err);
             test.equal(2, docs.length);
-            done();
             client.close();
+            done();
           });
         });
       });