New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-2723 Make mongos_clients a class property #1563

Merged

blink1073 merged 1 commit into mongodb:master from blink1073:PYTHON-2723-2

Mar 27, 2024

+1 −0

Member

blink1073 commented Mar 27, 2024 •

edited

Loading

Addresses Astrolabe failure: https://spruce.mongodb.com/task/drivers_atlas_testing_tests_python__driver~pymongo_master_platform~ubuntu_22.04_runtime~python39_atlas_retryWrites_resizeCluster_6603d586d05b2a00076119d2_24_03_27_08_15_02/logs?execution=0


          PYTHON-2723 Make mongos_clients a class property

44e8e23

mongodb-drivers-pr-bot bot requested a review from caseyclements

March 27, 2024 10:58

Member Author

blink1073 commented Mar 27, 2024

I opened https://jira.mongodb.org/browse/PYTHON-4303 for the other failures.

ShaneHarvey approved these changes

View reviewed changes

Member

ShaneHarvey commented Mar 27, 2024 •

edited

Loading

Wait is the problem that astrolabe never runs setUpClass()? https://github.com/mongodb-labs/drivers-atlas-testing/blob/93925b2/integrations/python/pymongo/workload-executor.py#L32-L36

Edit: Calling setUpClass is arguably better but this change still LGTM to get the testing passing again.

blink1073 merged commit e68bd6f into mongodb:master

72 of 75 checks passed

blink1073 deleted the PYTHON-2723-2 branch

March 27, 2024 18:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet