Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aggregation builder for $search stage, option count is a document #1558

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jan 3, 2025

https://www.mongodb.com/docs/atlas/atlas-search/counting/#std-label-count-ref

Also adding tests for the properties of $search stage.

@GromNaN GromNaN added the bug label Jan 3, 2025
@GromNaN GromNaN requested a review from a team as a code owner January 3, 2025 18:29
@GromNaN GromNaN requested a review from jmikola January 3, 2025 18:29
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks fine but two questions.

generator/config/stage/search.yaml Show resolved Hide resolved
generator/config/stage/search.yaml Show resolved Hide resolved
@GromNaN GromNaN enabled auto-merge (squash) January 6, 2025 09:15
@GromNaN GromNaN merged commit fb692ca into mongodb:v1.x Jan 6, 2025
31 checks passed
@GromNaN GromNaN deleted the fix-search-count branch January 7, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants