Trailing comma setting adjustment #21
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,7 @@ async function run() { | |||
| } | |||
| if (result.upsertedCount === 1) { | |||
| console.log( | |||
| "Inserted one new document with an _id of " + result.upsertedId._id, | |||
| "Inserted one new document with an _id of " + result.upsertedId._id | |||
There was a problem hiding this comment.
String interpolation?
ccho-mongodb
approved these changes
Feb 25, 2020
ccho-mongodb
pushed a commit
to ccho-mongodb/docs-node
that referenced
this pull request
Sep 23, 2022
* update prettier resource file to keep trailing commas on objects, but not functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current configuration enforces trailing commas on multi-line constructions. I would suggest that we continue to enforce trailing commas on objects, but omit them from function calls. See my second commit for an example of how trailing commas on function calls can have slightly baffling results.