* Dart/Flutter 1.9 compatibility

[TobiasHeidingsfeld]

Since updating to Flutter 1.9 /Dart 2.5 mongo_dart does not work due to change in List to Uint8List. Pull request fixes this

[Pacane]

Thank you!

[Pacane]

The tests are breaking, can you take a look?

[TobiasHeidingsfeld]

added a new commit for failing test´s

[ShivamArora]

@TobiasHeidingsfeld Thanks for being quick and taking efforts to resolve this issue.

When can we expect this to get stable, merged and released through the pub package manager so that we can upgrade to Flutter 1.9.0?

[thosakwe]

I just looked into why the tests are failing. From what I've gathered, MongoDB 3.6 modified the way that aggregate works, so the cursor is mandatory: https://docs.mongodb.com/manual/reference/command/aggregate/

I wonder how backwards-compatible that change is. It may be possible to test agains different MongoDB versions in Travis (or just declare that we target 3.6 after some version, etc.).

TL;DR - The PR itself is correct, but we may have to update the aggregate tests to get Travis to be happy.

[steve-cahn]

Is the current solution to downgrade to flutter 1.9.0?

[thumbert]

The test that fails is an old issue. See #120 You can work around it. But you can't work around this issue if you want to upgrade to Dart 2.5.0.

[thosakwe]

@Pacane Am I ok to merge the PR, and publish a patch (with the test fixed)?

[Pacane]

Sure!

…

On Mon., Sep. 16, 2019, 20:39 Tobe Osakwe, ***@***.***> wrote: @Pacane <https://github.com/Pacane> Am I ok to merge the PR, and publish a patch (with the test fixed)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#159?email_source=notifications&email_token=AAVCNSH6RBWOJTCJB52DHF3QKARM7A5CNFSM4IVQSX22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD625NNY#issuecomment-532010679>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVCNSDIQ4AWOAQONU3SA4TQKARM7ANCNFSM4IVQSX2Q> .

[TobiasHeidingsfeld]

Let me know when the new version is up on pub.dev as I have an package building onto of mongo_dart and will need to update the depedency! Thank you for the great package.

[a14n]

Regardless the test issue I believe the right fix is the change I did in #162 because it should be compatible with Dart<2.5 (and is the changes advised by Dart 2.5 CHANGELOG)

[thosakwe]

Resolved, see the discussions at #159, #160, and #162. https://pub.dev/packages/mongo_dart/versions/0.3.6