#313 populate searchdata even if hoverinfo === 'none' #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otherwise hoverinfo will be undefined
…if hoverinfo is set to none
…e hover info even if hovermode is set to false
… wasn't enough sometimes
…on of the hover info even if hovermode is set to false" This reverts commit a045927.
… preexisting option "hoverinfo" : "none"
monfera
added a commit
that referenced
this pull request
Feb 6, 2017
monfera
added a commit
that referenced
this pull request
Feb 6, 2017
monfera
added a commit
that referenced
this pull request
Feb 12, 2017
monfera
added a commit
that referenced
this pull request
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because otherwise eventData will be undefined, and as such, the click handler won't actually be called on click. (Btw. I could make the click handler be invoked even if eventData were undefined, but most realistic click handlers do need actual data to work with.)
CR: plotly#313