Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix varint decoding #174

Merged
merged 12 commits into from
Sep 29, 2023
Merged

Conversation

stringhandler
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/consensus/encode.rs 66.1% <100.0%> (+0.9%) ⬆️

📢 Thoughts on this report? Let us know!.

fuzz/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Boog900 Boog900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting + fixing this!

Just one question why do we need the idea files?

also this will need a change log entry

@stringhandler
Copy link
Contributor Author

updated

@Boog900 Boog900 merged commit 08d5e13 into monero-rs:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants