refactor(models)!: remove duplicated SubAddressIndex #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCharlatan
requested changes
Jul 8, 2022
|
@TheCharlatan done. |
6c67dd2 to
808517b
Compare
|
Just wondering if I should split the current item on |
|
Yes, that is possible. Check the rubrics here: https://github.com/monero-rs/monero-rs/blob/main/CHANGELOG.md |
808517b to
8469c12
Compare
|
Oh cool, PRs are mentioned in the other project. Added to this one. |
refring
pushed a commit
to refring/monero-rpc-rs
that referenced
this pull request
Oct 16, 2022
* refactor(models)!: remove duplicated SubAddressIndex * docs(changelog): update Unreleased section of changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
Decided to remove
SubAddressIndexinstead ofSubaddressIndexbecause there are other structs inmodels.rswhose name start withSubaddress(with lowercasea).No farcaster project used
SubAddressIndex, but I marked the commit with a!(as per https://www.conventionalcommits.org/en/v1.0.0/) to indicate that this is possibly a breaking change (in case anyone imported it in their projects).